Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate save of user status #364

Merged
merged 1 commit into from May 25, 2022
Merged

Remove duplicate save of user status #364

merged 1 commit into from May 25, 2022

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch removes a 2nd save of user status from the session state machine.

@bboudaoud-nv bboudaoud-nv added bug Something isn't working enhancement New feature or request labels Apr 13, 2022
@bboudaoud-nv bboudaoud-nv self-assigned this Apr 13, 2022
@jspjutNV jspjutNV added this to the Next Release (mid 2022) milestone Apr 13, 2022
@bboudaoud-nv
Copy link
Collaborator Author

bboudaoud-nv commented May 25, 2022

There were previously 2 calls made to FPSciApp::saveUserStatus() in Session.cpp. This branch removes the call from Session::updatePresentationState() in favor of the call in FPSciApp::markSessionComplete() (also called from Session::updatePresentationState()). This makes sense as it keeps the saveUserStatus() call contained inside of the FPSciApp and avoids the duplicate call we had previously.

@jspjutNV
Copy link
Contributor

I found the other save that we're keeping. It's in m_app->markSessComplete which is called in the trialFeedback state right before it transitions to the sessionFeedback state.

@jspjutNV jspjutNV merged commit 4b182ce into master May 25, 2022
@jspjutNV jspjutNV deleted the UserStatusLeakFix branch May 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants