Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getenv null check #399

Merged
merged 2 commits into from Nov 30, 2022
Merged

Getenv null check #399

merged 2 commits into from Nov 30, 2022

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch adds support for null checking results of std::getenv() calls which can be null when the requested values aren't set in the environment variables (as documented here).

Merging this PR closes #398.

@bboudaoud-nv bboudaoud-nv added the bug Something isn't working label Nov 29, 2022
@bboudaoud-nv bboudaoud-nv self-assigned this Nov 29, 2022
@bboudaoud-nv bboudaoud-nv marked this pull request as ready for review November 29, 2022 22:16
jspjutNV
jspjutNV approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@jspjutNV jspjutNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume the switch to forceAll = false isn't too important since we don't write out system config Any files often and if we do, we don't care about most of the values.

@jspjutNV jspjutNV merged commit b787b50 into master Nov 30, 2022
@jspjutNV jspjutNV deleted the GetenvNullCheck branch November 30, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspjutNV jspjutNV jspjutNV approved these changes

Assignees

@bboudaoud-nv bboudaoud-nv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getenv("USERNAME") failures in some cases
2 participants
@bboudaoud-nv @jspjutNV