Fixes for reticle preview and allowReticleChange
#404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboudaoud-nv
added
bug
bboudaoud-nv
changed the title
allowReticleChange
|
A fuller list of changes in this branch include:
|
jspjutNV
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a buggy interaction between specifying reticle configuration parameters at the experiment/session/trial level and using
allowReticleChange = trueto enable the user menu reticle configuration GUI.The app now treats specifying any reticle configuration at the experiment/session/trial level as equivalent to setting the corresponding field's
allowReticle[X]Changeparameter tofalse. Thus the only reticle parameters users are free to configure are those not specified as part of experiment configuration.Merging this PR closes #361