Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify widget manager prior to reinit #411

Merged
merged 1 commit into from Jan 13, 2023
Merged

Don't modify widget manager prior to reinit #411

merged 1 commit into from Jan 13, 2023

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch fixes exceptions thrown when changing experiments using the GUI in debug mode. The fix is simply not to modify the m_widgetManager prior to reinitializing the application.

@bboudaoud-nv bboudaoud-nv added the bug Something isn't working label Jan 10, 2023
@bboudaoud-nv bboudaoud-nv self-assigned this Jan 10, 2023
jspjutNV
jspjutNV approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@jspjutNV jspjutNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this introduces a memory leak, but since it fixes an annoying debug exception, I approve it. Might be worth keeping an eye on if we run into other issues.

@jspjutNV jspjutNV merged commit dfd2657 into master Jan 13, 2023
@jspjutNV jspjutNV deleted the ExperimentChangeFix branch January 13, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspjutNV jspjutNV jspjutNV approved these changes

Assignees

@bboudaoud-nv bboudaoud-nv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bboudaoud-nv @jspjutNV