Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load weapon sounds if audio disabled #414

Merged
merged 1 commit into from Jan 14, 2023
Merged

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch fixes an issue in the Weapon::loadSounds() call that was creating an exception when audioEnable was set to false in the startup config.

Merging this branch closes #413.

@bboudaoud-nv bboudaoud-nv added the bug Something isn't working label Jan 14, 2023
@bboudaoud-nv bboudaoud-nv self-assigned this Jan 14, 2023
Copy link
Contributor

@jspjutNV jspjutNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@jspjutNV jspjutNV merged commit af0a8ec into master Jan 14, 2023
@jspjutNV jspjutNV deleted the AudioDisableFix branch January 14, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting audioEnable to false in startup config causes a crash
2 participants