Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for VS 2022 #422

Merged
merged 4 commits into from Apr 13, 2023
Merged

Updates for VS 2022 #422

merged 4 commits into from Apr 13, 2023

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch updates the FPSci solution to work with visual studio 2022 (from 2019). In addition to updating the PlatformToolset to v143 this branch also updates the google test package to version 1.8.1.7.

@bboudaoud-nv bboudaoud-nv added the enhancement New feature or request label Mar 15, 2023
@bboudaoud-nv bboudaoud-nv self-assigned this Mar 15, 2023
@bboudaoud-nv bboudaoud-nv marked this pull request as ready for review March 29, 2023 15:09
jspjutNV
jspjutNV approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@jspjutNV jspjutNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with G3D r7220 and it appears to work. I also updated the readme.md to reflect the new VS and G3D version requirements.

@jspjutNV jspjutNV merged commit 3fbdc80 into master Apr 13, 2023
@jspjutNV jspjutNV deleted the vs2022 branch April 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspjutNV jspjutNV jspjutNV approved these changes

Assignees

@bboudaoud-nv bboudaoud-nv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bboudaoud-nv @jspjutNV