Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with OpenEXR images with more channels than RGB #31

Merged

Conversation

Latios96
Copy link
Contributor

This PR fixes issue #30

To me it seems like numRecognizedChannels and exrHeader.num_channels were confused. Using numRecognizedChannels instead of exrHeader.num_channels seems more appropriate when loading the data, since the OpenEXR image can contain an arbitrary amount of (unused) channels.

I don't know if this is the best fix, but it worked for me.

@inversepixel
Copy link
Collaborator

Thanks so much! This is really how the code should have worked... this is the first time I encounter EXR images with more channels, so the code has never really been tested.
Anyway, I removed some of the previous warnings and minor cleanup as well. You can see here, if you are interested:
de24b93

@Latios96
Copy link
Contributor Author

Your welcome, great it is fixed and simplified now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants