-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better colmap2nerf script #1051
Open
VanIseghemThomas
wants to merge
8
commits into
NVlabs:master
Choose a base branch
from
VanIseghemThomas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 5, 2022
-
Added num_threads argument preventing system freeze
Without this, colmap will use up all available resources. This results in the system freezing due to no resources available. Adding this argument caps the resources and allows the system to function as normal.
Configuration menu - View commit details
-
Copy full SHA for 33897d0 - Browse repository at this point
Copy the full SHA 33897d0View commit details -
Automatically create transform.json file in specified path
Before you had to specify the path with "transform.json" at the end, else the script went in error. Now "transform.json" will be appended to the path resulting in it being created without specifying it every time.
Configuration menu - View commit details
-
Copy full SHA for a8b9c44 - Browse repository at this point
Copy the full SHA a8b9c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e84c01 - Browse repository at this point
Copy the full SHA 2e84c01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2618a21 - Browse repository at this point
Copy the full SHA 2618a21View commit details -
Fixed transforms.json wrong file_path
All path locations are handled to put the transforms.json in the right location and populate the frames-object with the right image file_path. Also wrapped them is a os.normpath to ensure cross platform functionallity. This might not be necesarry but is a good assurance.
Configuration menu - View commit details
-
Copy full SHA for 314656c - Browse repository at this point
Copy the full SHA 314656cView commit details
Commits on Nov 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c319b7f - Browse repository at this point
Copy the full SHA c319b7fView commit details
Commits on Nov 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 72f81a1 - Browse repository at this point
Copy the full SHA 72f81a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6591eb - Browse repository at this point
Copy the full SHA b6591ebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.