Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 2 typos on the Neural_Receiver.ipynb notebook #406

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

pablosreyero
Copy link
Contributor

Just fixed 2 typos on the Neural Receiver notebook. I substituted "receover" with "receiver"

Description

A clear and concise description of what this pull request does.

I just fixed 2 typos in 2 comments on the Neural Receiver tutorial. I substituted "receover" with "receiver" in 2 code cells of these 2 sections: End-to-end System and End-to-end System as a Keras-Model.

  • Fixes a bug?

No, it just fixes 2 typos in 2 code comments.

Describe what was wrong, and explain the solution in detail.

  • Adds a new feature?

No.

Describe the new feature, ensure that it is properly documented. Note that for new features unit tests are required.

  • Introduces API changes?

No.

Address in detail why it is needed. Explain and describe the consequences, does it break older code? Note that API changes might be delayed until a major bump release for inclusion.

  • Other contributions

Not other contributions.

Please detail the nature of the submission.

I was just checking out the Neural Receiver tutorial and I noticed the 2 above mentioned typos in 2 cell comments, and I decided to fix them and open a pull request.

Checklist

  • Detailed description
  • Added references to issues and discussions
  • Added / modified documentation as needed
  • Added / modified unit tests as needed
  • Passes all tests
  • Lint the code
  • Performed a self review
  • Ensure you Signed-off the commits. Required to accept contributions!
  • Co-authored with someone? Add Co-authored-by: user@domain and ensure they signed off their commits too.

I think there's no need to put my GH signature here, since I already signed my commit, but just in case...

Signed-off-by: Pablo Suárez pablosreyero@gmail.com

Just fixed 2 typos on the Neural Receiver notebook. I substituted "receover" with "receiver"

Signed-off-by: Pablo Suárez <pablosreyero@gmail.com>
@jhoydis jhoydis merged commit 34fa468 into NVlabs:main Apr 23, 2024
4 checks passed
@merlinND
Copy link
Collaborator

Thanks for these fixes @pablosreyero!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants