Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuu_1.3.154{.zip,.tar.gz} are missing .tarball-version #173

Closed
OsterlaD opened this issue Mar 25, 2020 · 12 comments
Closed

uuu_1.3.154{.zip,.tar.gz} are missing .tarball-version #173

OsterlaD opened this issue Mar 25, 2020 · 12 comments

Comments

@OsterlaD
Copy link
Contributor

Hi @nxpfrankli ,

is it not possible to add the .tarball-version file to the source tarball, as suggested in the pull request?
I have found some artifacts but not the source archives. Where is the source tarball generation? Does it appveyor automatically?

See: #171
See: #77

@nxpfrankli
Copy link
Contributor

It is generated by github when publish release.

@OsterlaD
Copy link
Contributor Author

oh. So the Problem is not jet fixed. Some may now be able to build from the source tarball with the extra step to write .tarball-version but this is not yet perfect. Do you know if it is possible to suppress automatically generated source archives and add custom?

@nxpfrankli
Copy link
Contributor

I don't know yet. I sent a request to github customer support. let wait for what github said?

@OsterlaD
Copy link
Contributor Author

Sounds good. Let's wait for the answer from support.

@OsterlaD
Copy link
Contributor Author

Hi,

nxp-imx/imx-uuc#12 (comment)

I guess this comment was for this issue.

It seems to be no problem. Look at https://github.com/MicrochipTech/cryptoauthlib/releases/tag/v3.1.0 the generated archive has archive in the URL but the uploaded archive has release in the URL. So it should be no problem. It might be a good idea to add a hint to the readme that only the uploaded archive builds.

Regards

@nxpfrankli
Copy link
Contributor

looks like script generate new source code package. it looks strange about there are two sets of source package

@OsterlaD
Copy link
Contributor Author

Hi, I see. But to build the program from tarball the info can not come from git, because the history is not there. In my opinion the added generated file has that advantage that it is easy to automate.
The other option would be a "prepare release" commit to store version number of release before release. This has option has the advantage that it works with all tarballs generated by GitHub and even works with git shallow clone. The decision is up to you. Regards

@nxpfrankli
Copy link
Contributor

@OsterlaD
Copy link
Contributor Author

Hi Frank, great job! It works!
Thanks you very much.

Looking forward for your official 163 release ;-)

@OsterlaD
Copy link
Contributor Author

Hi @nxpfrankli ,
one question about the uuu_source-1.3.167.tar.gz.
In compare to uuu-1.3.163.tar.gz (your link above) the new tarball has two top-level directories.
The 163 contains only uuu-1.3.163 directory, but 167 contains uuu-1.3.167 and uuu_source-1.3.167.
Was this an accident or has it some special meaning?
Regards

@nxpfrankli
Copy link
Contributor

Sorry, it is caused by I rename it. try 169 pre-release

@OsterlaD
Copy link
Contributor Author

OsterlaD commented Apr 20, 2020

There it is only one toplevel dir, perfect.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants