Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails because it uses pyyaml wrong #45

Closed
dvzrv opened this issue Jul 31, 2022 · 1 comment
Closed

Test fails because it uses pyyaml wrong #45

dvzrv opened this issue Jul 31, 2022 · 1 comment

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Jul 31, 2022

Upon trying to package 1.7.0 for Arch Linux I ran the test suite.
Unfortunately test_generate_template uses pyyaml wrong, by attempting to use load() without a loader (see documentation). It is unclear how that test has ever passed NXP's internal CI, as at least the latest versions of pyyaml do not support calling load() like that.

@mwsk
Copy link
Contributor

mwsk commented Sep 19, 2022

This has been solved in 1.7.1 release using: safe_load()
data = yaml.safe_load(f)

@mwsk mwsk closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants