Add /bbl route #438
Merged
Add /bbl route #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
pichot
commented
Dec 5, 2017
| import bblDemux from '../utils/bbl-demux'; | ||
|
|
||
| export default Ember.Route.extend({ | ||
| model(params) { |
There was a problem hiding this comment.
@allthesignals is this the right hook to use? I tried beforeModel but it appeared that the params weren't fully loaded.
There was a problem hiding this comment.
@pichot yes - beforeModel doesn't have the params object in the signature directly, you'd have to access it differently.
|
Rebased and ready to merge please :) |
|
|
||
| export default Ember.Route.extend({ | ||
| model(params) { | ||
| const bbl = bblDemux(params.bbl); |
There was a problem hiding this comment.
You might also have said:
export default Ember.Route.extend({
model({ bbl }) {
const { boro, block, lot } = bblDemux(bbl);
this.transitionTo('lot', boro, block, lot);
}
});There was a problem hiding this comment.
oooh, better. Should have waited for your code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple commit that adds a
/bblroute. Uses already implementedbbl-demuxto parse bbl and redirect to/lotroute.Unit and acceptance tests included.