OE-215: Implement support for OAuth Client Credentials #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnga
changed the title
MalcolmMcFly
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
AccountProviderAuthenticationDescriptionand related parsers. With this authentication type, credentials for basic auth are still used inAccountReadalbleType.loggingState.AccountAuthenticationHelpers. When logged it, it's not based any more only on credentials, but on the full account. If OAuth Client Credentials is supported by the account provider, authentication URI is passed to the request andSimplified-Android-HTTPwill get and cache an OAuth token.Why are we doing this? (w/ JIRA link if applicable)
https://jira.nypl.org/browse/OE-215
How should this be tested? / Do these changes have associated tests?
Check that requests are intercepted in the logs.
Dependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
Yes, I did.