At most one adobe vendor id per circ manager #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on into nypl-deploy-qa
…on into nypl-deploy-qa
…on into nypl-deploy-qa
…on into nypl-deploy-qa
…on into nypl-deploy-qa
…on into nypl-deploy-qa
aslagle
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a productization of a hotfix.
A circulation manager can host at most one library with an Adobe Vendor ID configuration. When a circ manager contains such a library, but also contains a library with no Vendor ID configuration, there's a nondeterministic risk that the second library will overwrite an existing
AdobeVendorIDControllerwithNone. This branch changes things so an AdobeVendorIDController is never overridden once created.This requires a server restart if for some reason the library responsible for the Adobe Vendor ID configuration changes, but that shouldn't happen until we remove this responsibility from the circulation manager altogether.