Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the confirmation workflow, which was broken in several places. #76

Merged
merged 2 commits into from Sep 5, 2018

Conversation

leonardr
Copy link
Contributor

@leonardr leonardr commented Sep 5, 2018

This branch fixes a number of problems with the email confirmation workflow, all of them located in untested routing code.

  • The confirm_resource function took the wrong arguments.
  • It referred to a LibraryRegistry.validation_controller object, but that object was not instantiated during startup.
  • It called the method ValidationController.validate when the actual name of the method is confirm.

I've done an end-to-end test locally to make sure there are no more problems with this process.

@leonardr leonardr merged commit 921967c into master Sep 5, 2018
@leonardr leonardr deleted the fix-confirmation-workflow branch September 5, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants