Add ProQuest integration #1208
Add ProQuest integration #1208
Conversation
model/work.py
Outdated
| def calculate_presentation( | ||
| self, policy=None, search_index_client=None, exclude_search=False, | ||
| default_fiction=None, default_audience=None | ||
| default_fiction=None, default_audience=Classifier.AUDIENCE_ADULT |
There was a problem hiding this comment.
@leonardr, I set default_audience to Classifier.AUDIENCE_ADULT instead of implementing SIMPLY-2610
There was a problem hiding this comment.
I think this is OK. Since this code was written we have had many incoming feeds with no audience information and the implication was always that the works are for adults.
There was a problem hiding this comment.
Christina pushed back a little in https://jira.nypl.org/browse/SIMPLY-2610; I'm waiting for her response. It may be better to simply implement 2610.
Another temporary way to solve this problem would be to continue to set audience=None for these books but to change the way books are placed into lanes. Specifically, we could say that a lanes whose audiences include AUDIENCE_ADULT or AUDIENCE_RESEARCH should also include any books that have no audience set.
The real problem we're trying to address is not that these books don't have an audience set (that's the most accurate conclusion -- we don't have the information) but that they don't show up in the default lanes.
There was a problem hiding this comment.
Based on the conversation with Christina in https://jira.nypl.org/browse/SIMPLY-2610, I don't think users will accept a change like this which adds metadata that was not provided by the vendor, the administrator, or a librarian.
My preference would be to resolve this by resolving SIMPLY-2610.
There was a problem hiding this comment.
Let me make this stronger: based on Christina's feedback I think you need to implement SIMPLY-2610 instead of setting this default.
There was a problem hiding this comment.
I created PR # 1214 in server_core and merged it to this branch.
vbessonov
force-pushed
the
feature/proquest-integration
branch
2 times, most recently
from
a2485ca
to
c0718fb
Compare
|
I suspect there may be some new files missing from this PR; there's nothing really Proquest-specific, there are no new tests, and you define an interface class that has no implementations. |
vbessonov
force-pushed
the
feature/proquest-integration
branch
from
5a739d3
to
442f714
Compare
vbessonov
force-pushed
the
feature/proquest-integration
branch
from
442f714
to
524bc2f
Compare
Description
This PR contains changes required for
ProQuestOPDS2Importerimplemented in PR # 1520.Motivation and Context
SIMPLY-3251
How Has This Been Tested?
Checklist: