This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
SCC-2271 Add missing statements to ES index #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor typo in the `Item` serializer was omitting the new `physicalLocation` and `enumerationChronology` fields due to a missing call to the object. This adds that call and extends one of the test bib records to include these fields, which supports a new unit test.
nonword
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor typo in the
Itemserializer was omitting the newphysicalLocationandenumerationChronologyfields due to a missing call to the object. This adds that call and extends one of the test bib records to include these fields, which supports a new unit test.This also includes a minor update to the travis caching, which was using an old style of reference that seemed to be causing issues for some reason.