Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points website searches to /search/ instead of /apachesolr_search/ #55

Closed
wants to merge 1 commit into from

Conversation

LucasCioffi
Copy link
Contributor

No description provided.

@@ -1,6 +1,9 @@
### CHANGE LOG

=======
### v2.4.12
> Point website searches to /search/ instead of /apachesolr_search/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is quite minor, but I think it is probably better use either "points" or "pointed" just to keep consistent with the verb tense?

@ktp242
Copy link
Contributor

ktp242 commented Nov 6, 2018

Just a minor suggestion. Other than that looks fine!

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Why did you close the previous PR and open a new one instead of just adding on top of the previous PR?

@LucasCioffi
Copy link
Contributor Author

@EdwinGuzman I closed the last PR because it would merge into Master. Is there a way to change that once it's created?

@LucasCioffi
Copy link
Contributor Author

I'm closing this one because I saw in the README I need to name the branch with the release-v.x.x.x format.
Replaced by #56

@LucasCioffi LucasCioffi closed this Nov 6, 2018
@LucasCioffi LucasCioffi deleted the redirect_search_queries branch November 6, 2018 20:57
@LucasCioffi LucasCioffi changed the title Point website searches to /search/ instead of /apachesolr_search/ Points website searches to /search/ instead of /apachesolr_search/ Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants