Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1702: responsive grid system #1591

Open
wants to merge 212 commits into
base: breakpoints-grid-feature-branch
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
212 commits
Select commit Hold shift + click to select a range
72f284f
Updating vite and other related packages
EdwinGuzman Apr 12, 2024
8629425
fixing storybook issue
EdwinGuzman Apr 12, 2024
48e79a2
Storybook 8
EdwinGuzman Apr 12, 2024
395e76f
adding missing file?
EdwinGuzman Apr 12, 2024
9abf6ba
storybook argtypes
EdwinGuzman Apr 12, 2024
997a54a
main change
EdwinGuzman Apr 15, 2024
3d9e209
Merge branch 'development' into DSD-1766/npm-package-update
EdwinGuzman Apr 16, 2024
e66ff4a
Minor update
EdwinGuzman Apr 16, 2024
ac93b77
Changelog and better storybook html defaults
EdwinGuzman Apr 18, 2024
ce9fbe0
Merge branch 'development' into DSD-1766/npm-package-update
EdwinGuzman Apr 18, 2024
b305062
forgot about downshift which is no longer used
EdwinGuzman Apr 18, 2024
8d2ed81
Updates based on feedback
EdwinGuzman Apr 19, 2024
900ad28
merging and fixing conflicts from development
EdwinGuzman Apr 19, 2024
7154431
Adding back ts
EdwinGuzman Apr 19, 2024
f1bc663
package.json update
EdwinGuzman Apr 19, 2024
e83e2cd
Merge pull request #1585 from NYPL/development
EdwinGuzman Apr 25, 2024
b295fd7
adjusted header styles
bigfishdesign13 Apr 26, 2024
e10a9ef
package-lock
bigfishdesign13 Apr 26, 2024
6741abe
merging and fixing conflicts from development
EdwinGuzman Apr 26, 2024
5b05b59
Component, tests, stories added
7emansell Apr 30, 2024
740525a
Name change to Confirmation
7emansell May 1, 2024
88b2d4d
Changelog
7emansell May 1, 2024
38cdf89
Clarifying usage in docs
7emansell May 1, 2024
4e0ed99
Commenting more in Modal
7emansell May 1, 2024
3f92bb9
More typos
7emansell May 1, 2024
813dd7e
More and more typos
7emansell May 1, 2024
add7440
Rearranging props
7emansell May 1, 2024
380bc86
Hard set of default to fix onClose
7emansell May 2, 2024
e9956eb
Edwin docs fixes
7emansell May 2, 2024
eaaaceb
Release candidate, making type prop explicit
7emansell May 2, 2024
a41e315
first step into adding ids
EdwinGuzman May 2, 2024
97fe5f4
Edwin/Marty updates: storybook, removing forwardRef
7emansell May 3, 2024
324214d
Adding more ids, tests, and changelog updates
EdwinGuzman May 3, 2024
d015f8d
merging and fixing conflicts
EdwinGuzman May 6, 2024
9567c0f
Rc 2
7emansell May 6, 2024
af8d668
new responsive grid system
bigfishdesign13 May 6, 2024
83b8b5f
Merge branch 'breakpoints-grid-feature-branch' into DSD-1702/template…
bigfishdesign13 May 7, 2024
bed344a
Updating prop error warning
7emansell May 7, 2024
d4d1d5c
comments cleanup
bigfishdesign13 May 7, 2024
8fd0785
better responsive column labelling
bigfishdesign13 May 7, 2024
7d01556
Merge branch 'development' into DSD-1773/1774/ids-as-props
EdwinGuzman May 9, 2024
e2f3cae
Merge pull request #1590 from NYPL/DSD-1773/1774/ids-as-props
EdwinGuzman May 9, 2024
972d1ad
prep for release 3.1.2.
EdwinGuzman May 9, 2024
fc1b322
Console warning corrected
7emansell May 9, 2024
4438643
Merge pull request #1592 from NYPL/release-3.1.2
EdwinGuzman May 9, 2024
2d1f61b
Merge branch 'release' into development
EdwinGuzman May 9, 2024
461c127
Merging from development
EdwinGuzman May 9, 2024
467e9e7
Merge pull request #1593 from NYPL/development
EdwinGuzman May 9, 2024
7f55578
fixing chakra export pages
EdwinGuzman May 9, 2024
689a761
Updating some files ?
EdwinGuzman May 9, 2024
87b0474
package-lock update
EdwinGuzman May 9, 2024
4a780ec
documentation
bigfishdesign13 May 9, 2024
70c58fd
package-lock
bigfishdesign13 May 9, 2024
e0eca9f
Final release candidate
7emansell May 10, 2024
d65665b
Merge branch 'development' into DSD-1762/modal-updates
7emansell May 10, 2024
9879abc
Returning to development version
7emansell May 10, 2024
d4ff6be
More version fixing..
7emansell May 10, 2024
ab7833e
Merge pull request #1587 from NYPL/DSD-1762/modal-updates
7emansell May 10, 2024
821e779
Merge branch 'development' of github.com:NYPL/nypl-design-system into…
EdwinGuzman May 10, 2024
249afc7
merge and also minor updates
EdwinGuzman May 10, 2024
02c1e94
Updating the association between the SearchBar's input element with t…
EdwinGuzman May 13, 2024
d5337b3
Exporting helper chakra functions
EdwinGuzman May 13, 2024
a0b3518
Fixing a breadcrumbs test to have the appropriate type for its snapsh…
EdwinGuzman May 13, 2024
8ab38c2
Adding interaction tests for RadioGroup
EdwinGuzman May 13, 2024
5d33a1e
adding showRowDividers prop to hide horizontal dividers in the descri…
EdwinGuzman May 13, 2024
0f39986
Fixing the desktop styling flicker in ButtonGroup
EdwinGuzman May 14, 2024
0f9decf
Merge pull request #1599 from NYPL/DSD-1777/buttongroup-flicker
EdwinGuzman May 14, 2024
a95d9e2
Prep for release 3.1.3
EdwinGuzman May 14, 2024
293108a
Fixing z-index issue on MultiSelect selected items count button
EdwinGuzman May 14, 2024
41ee071
set useLegacyGrid to default to false
bigfishdesign13 May 14, 2024
b870ce8
Merge pull request #1600 from NYPL/release-3.1.3
EdwinGuzman May 15, 2024
f5711db
Merge pull request #1602 from NYPL/development
EdwinGuzman May 15, 2024
1350033
Fixing checkbox's positioning so it is visible when focused in scroll…
EdwinGuzman May 15, 2024
2cc8cce
Updating snapshot tests
EdwinGuzman May 15, 2024
7446774
Merge branch 'development' into DSD-1742/multiselect-z-index
EdwinGuzman May 16, 2024
af248bb
Merge pull request #1601 from NYPL/DSD-1742/multiselect-z-index
EdwinGuzman May 16, 2024
022ca16
Merge branch 'development' into DSD-1741/multiselect-scrollintoview
EdwinGuzman May 16, 2024
e6ed26d
Merge pull request #1603 from NYPL/DSD-1741/multiselect-scrollintoview
EdwinGuzman May 16, 2024
99b5862
alphabetize textinput args for getAriaAttrs
EdwinGuzman May 16, 2024
1d393e7
merging and fixing conflicts from development
EdwinGuzman May 16, 2024
2547d74
Merge pull request #1596 from NYPL/DSD-1565/breadcrumbs-snapshot-test…
EdwinGuzman May 16, 2024
709e1ba
merging and fixing conflicts from development
EdwinGuzman May 16, 2024
d4ace9e
Merge pull request #1595 from NYPL/DSD-1735/missing-chakra-exports
EdwinGuzman May 16, 2024
6fffef9
updates based on comments
bigfishdesign13 May 16, 2024
172a6f8
Updates Accordion to close when esc is pressed
oliviawongnyc May 17, 2024
1190ff1
Updates logic
oliviawongnyc May 17, 2024
2367b1e
Cleans up code
oliviawongnyc May 20, 2024
756d945
More clean up
oliviawongnyc May 20, 2024
541926a
Merges in development
oliviawongnyc May 20, 2024
4147dbe
Updates snapshots
oliviawongnyc May 20, 2024
62237f0
merging and fixing conflicts from development
EdwinGuzman May 20, 2024
a9d1570
testing style rules
EdwinGuzman May 21, 2024
0201f9d
package-lock update
EdwinGuzman May 21, 2024
6cdf2ec
fixin zindex issue on multiselect count button
EdwinGuzman May 22, 2024
c382aff
Adds keydown listener
oliviawongnyc May 22, 2024
277e7ef
Updates per PR feedback
oliviawongnyc May 22, 2024
7a13b27
Merge pull request #1604 from NYPL/DSD-1775/add-esc-func-to-accordion
oliviawongnyc May 22, 2024
ac6f48a
Merge branch 'development' into DSD-1740/close-dropdown-multiselect
oliviawongnyc May 22, 2024
a29d3d5
Merging and fixing conflicts from development
EdwinGuzman May 22, 2024
68ae288
Merge pull request #1594 from NYPL/DSD-1582/searchbar-describedby
EdwinGuzman May 22, 2024
d941227
routine update from development
EdwinGuzman May 22, 2024
6ff9f67
Merge branch 'development' into no_ref/multiselect_count_btn_fix
EdwinGuzman May 22, 2024
25aa590
Merge pull request #1606 from NYPL/no_ref/multiselect_count_btn_fix
EdwinGuzman May 22, 2024
12e4a8d
merging and fixing conflicts from development
EdwinGuzman May 22, 2024
ce69389
Merge pull request #1598 from NYPL/DSD-1729/dl-dividers
EdwinGuzman May 22, 2024
27e67ec
Adds logic to close accordion when inner element is focused
oliviawongnyc May 22, 2024
2bee9f1
Merges in development
oliviawongnyc May 22, 2024
7826fcd
Updates per PR feedback
oliviawongnyc May 23, 2024
30f7292
3.1.4
bigfishdesign13 May 23, 2024
1d23754
Prep for Release v3.1.4
bigfishdesign13 May 23, 2024
a310931
Merge pull request #1609 from NYPL/release-3.1.4
bigfishdesign13 May 23, 2024
c516681
Merge branch 'release' into development
EdwinGuzman May 23, 2024
9587562
Merge pull request #1610 from NYPL/development
bigfishdesign13 May 23, 2024
ef113fa
Updates per PR feedback
oliviawongnyc May 24, 2024
9aa13ae
Fixes tests
oliviawongnyc May 24, 2024
41fd411
Updates per feedback
oliviawongnyc May 29, 2024
1178b00
Updates documentation
oliviawongnyc May 29, 2024
5fe333a
First pass at search bar tests
7emansell May 29, 2024
0bff5ab
Tests updated to include clear button
7emansell May 30, 2024
19f4088
Merge branch 'development' into DSD-1749/searchbar-storybook-interact…
7emansell May 30, 2024
0dde12c
Code example error
7emansell May 31, 2024
81afe1f
Adding use section
7emansell Jun 3, 2024
d56435a
Heading
7emansell Jun 3, 2024
6a50d6d
Merging and fixing conflicts from development
EdwinGuzman Jun 3, 2024
b09c0f1
Merge pull request #1580 from NYPL/DSD-1766/npm-package-update
EdwinGuzman Jun 4, 2024
7aeb0b8
Merging and fixing conflicts from development
EdwinGuzman Jun 4, 2024
fac53c2
selectOptions interaction test
7emansell Jun 4, 2024
e109e9d
No need for non working test
7emansell Jun 4, 2024
884dce6
Merge branch 'development' into no_ref/modal-docs-update
7emansell Jun 4, 2024
49794ea
Adding some expectations
EdwinGuzman Jun 5, 2024
5afbb08
Merge branch 'development' into DSD-1692/heading-link-test
EdwinGuzman Jun 5, 2024
5d4f116
Cleaning up PR
EdwinGuzman Jun 5, 2024
13dc234
Adding expectations
7emansell Jun 5, 2024
ef40a1f
Changelog
7emansell Jun 5, 2024
3f906a9
Changelog
7emansell Jun 5, 2024
0d03c84
3.1.5
bigfishdesign13 Jun 6, 2024
d6c9d2b
Prep for Release v3.1.5
bigfishdesign13 Jun 6, 2024
3e24847
More additions for clarity
7emansell Jun 6, 2024
e23180d
Fixing changelog details
EdwinGuzman Jun 6, 2024
97ae7fb
Merge pull request #1615 from NYPL/release-3.1.5
bigfishdesign13 Jun 6, 2024
ae8ae25
Merge branch 'release' into development
EdwinGuzman Jun 6, 2024
45440ca
Merge pull request #1616 from NYPL/development
bigfishdesign13 Jun 6, 2024
2b599a9
Merge branch 'development' into DSD-1749/searchbar-storybook-interact…
7emansell Jun 6, 2024
aa52fa1
Merge branch 'development' into no_ref/modal-docs-update
7emansell Jun 6, 2024
6607141
Merge pull request #1612 from NYPL/no_ref/modal-docs-update
7emansell Jun 7, 2024
e9cd659
Merge branch 'development' into DSD-1750/select-interaction-tests
7emansell Jun 7, 2024
5bad78d
Adding expectations
7emansell Jun 7, 2024
162e374
Merge pull request #1614 from NYPL/DSD-1750/select-interaction-tests
7emansell Jun 7, 2024
55c0ccb
Merging and fixing conflicts from development
EdwinGuzman Jun 10, 2024
1fcd103
package-lock update
EdwinGuzman Jun 10, 2024
ea3f515
Merge pull request #1597 from NYPL/DSD-1748/radiogroup-interaction-tests
EdwinGuzman Jun 10, 2024
ba120a8
Merging and fixing conflicts from development
EdwinGuzman Jun 10, 2024
5e11157
Merge branch 'development' into DSD-1749/searchbar-storybook-interact…
7emansell Jun 10, 2024
821555f
Updating based on feedback
EdwinGuzman Jun 10, 2024
d3be6a7
Merge pull request #1611 from NYPL/DSD-1749/searchbar-storybook-inter…
7emansell Jun 10, 2024
03a4aac
Remove BlinkMac and applesystem fonts
7emansell Jun 10, 2024
d0d7cac
Changelog
7emansell Jun 10, 2024
005ce68
merging and fixing conflicts from development
EdwinGuzman Jun 10, 2024
f102bda
Merge pull request #1605 from NYPL/DSD-1692/heading-link-test
EdwinGuzman Jun 10, 2024
f2806a2
Moving github_token value in env property for tag release Github Action
EdwinGuzman Jun 10, 2024
42ab152
Adds ability to close MultiSelect on blur
oliviawongnyc Jun 12, 2024
9385fa4
Adds to documentation
oliviawongnyc Jun 12, 2024
e1e5795
Merge branch 'development' into DSD-1778/font-stack-update
7emansell Jun 12, 2024
0e3e639
specific version for action-autotag github action package
EdwinGuzman Jun 17, 2024
bee4218
Merge pull request #1619 from NYPL/DSD-1685/ga-tag-update
EdwinGuzman Jun 17, 2024
bf7958c
Adding interaction tests for CheckboxGroup
EdwinGuzman Jun 17, 2024
83b59ce
Adding interaction tests for DatePicker
EdwinGuzman Jun 17, 2024
d5bd5be
Adding interaction tests for Slider component
EdwinGuzman Jun 18, 2024
080bdfc
Updating a few jest-related npm packages
EdwinGuzman Jun 18, 2024
5b4599d
package-lock update
EdwinGuzman Jun 18, 2024
ee31192
3.1.6
bigfishdesign13 Jun 20, 2024
4ddc912
Prep for Release v3.1.6
bigfishdesign13 Jun 20, 2024
bda6fe7
adding tests for tabbing and keyboard input
EdwinGuzman Jun 20, 2024
f985f5a
Merge branch 'development' into DSD-1778/font-stack-update
7emansell Jun 20, 2024
71af5e0
Merge pull request #1626 from NYPL/release-3.1.6
bigfishdesign13 Jun 20, 2024
106d2a1
Merge branch 'release' into development
EdwinGuzman Jun 20, 2024
7b52c78
updating package-lock
EdwinGuzman Jun 20, 2024
86750ac
updating package-lock
EdwinGuzman Jun 20, 2024
c3e7b3b
Merge branch 'development' into DSD-1778/font-stack-update
7emansell Jun 21, 2024
1526f36
Merge pull request #1618 from NYPL/DSD-1778/font-stack-update
7emansell Jun 21, 2024
42fd5c1
Merging and fixing conflicts from development
EdwinGuzman Jun 21, 2024
ab33aaf
Merge pull request #1621 from NYPL/DSD-1744/checkboxgroup-interaction…
EdwinGuzman Jun 21, 2024
048d829
Merging and fixing conflicts from development
EdwinGuzman Jun 21, 2024
48b67a8
Merge pull request #1622 from NYPL/DSD-1745/datepicker-interaction-tests
EdwinGuzman Jun 21, 2024
f636ebc
Merging and fixing conflicts from development
EdwinGuzman Jun 21, 2024
75340ac
Merge pull request #1624 from NYPL/DSD-1751/slider-interaction-tests
EdwinGuzman Jun 21, 2024
262a5b1
Merge branch 'development' into DSD-1740/close-dropdown-multiselect
oliviawongnyc Jun 24, 2024
0bc9a58
Updates per PR feedback
oliviawongnyc Jun 24, 2024
e3c6559
Tests and changelogs
7emansell Jun 24, 2024
b6cbb65
Adding type and example in storybook
7emansell Jun 24, 2024
f709a00
Cleans up
oliviawongnyc Jun 24, 2024
d3e45dd
CHANGELOG cleanup
oliviawongnyc Jun 24, 2024
bae5120
Merge pull request #1607 from NYPL/DSD-1740/close-dropdown-multiselect
oliviawongnyc Jun 25, 2024
78a7b94
More updates per feedback
oliviawongnyc Jun 25, 2024
9b03e4b
Updates snapshot
oliviawongnyc Jun 25, 2024
4cda43b
Separates handleEvent function into two
oliviawongnyc Jun 26, 2024
dc60e5b
Corrected colors and changelogs
7emansell Jun 26, 2024
b254c18
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
7emansell Jun 26, 2024
1e31465
Alphabetized, focus color updated
7emansell Jun 26, 2024
6f395c6
Adding more tests with the email and radio button fields
7emansell Jun 26, 2024
2cd9292
Merge branch 'development' into DSD-1746/feedback-interaction-tests
7emansell Jun 26, 2024
1c58b68
Updates docs per feedback
oliviawongnyc Jun 26, 2024
970f14c
Merge pull request #1620 from NYPL/DSD-1787/close-multiselect-on-blur
oliviawongnyc Jun 26, 2024
f600cbb
Merge branch 'development' into DSD-1746/feedback-interaction-tests
7emansell Jun 27, 2024
bbd6588
alphabetize fully
7emansell Jun 28, 2024
87314c7
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
7emansell Jun 28, 2024
40e9625
Merge pull request #1628 from NYPL/DSD-1746/feedback-interaction-tests
7emansell Jun 28, 2024
4892697
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
7emansell Jun 28, 2024
0340dda
Merge pull request #1629 from NYPL/DSD-1795/breadcrumbs-dc-variant
7emansell Jun 28, 2024
532b399
Merging and fixing conflicts from development
EdwinGuzman Jun 28, 2024
ff5428d
Merge pull request #1625 from NYPL/no_ref/jest-routine-package-update
EdwinGuzman Jun 28, 2024
793283a
merge from development branch
bigfishdesign13 Jul 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ const config: StorybookConfig = {
// docs: {
// autodocs: true,
// },

// Configures a static asset folder in Storybook
staticDirs: ["../public"],
};

export default config;
41 changes: 39 additions & 2 deletions .storybook/preview-body.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@
}
/* It is unclear if this style override is necessary. Until this is
determined, the code will be left in place and simply commented out. */
/*
/*
.sbdocs :where(h1:not(.sb-unstyled h1)),
.sbdocs :where(h2:not(.sb-unstyled h2)),
.sbdocs :where(h3:not(.sb-unstyled h3)),
.sbdocs :where(h4:not(.sb-unstyled h4)),
.sbdocs :where(h5:not(.sb-unstyled h5)),
.sbdocs :where(h6:not(.sb-unstyled h6)) {
color: unset;
}
}
*/
.sbdocs :where(div:not(.sb-anchor, .sb-unstyled, .sb-unstyled div)) {
color: inherit;
Expand Down Expand Up @@ -123,4 +123,41 @@
.sb-show-main table.storybook-colors-example tbody td:last-of-type {
border: unset;
}
/* NYPL Table component for Storybook */
.ds-table-storybook tr {
background-color: transparent !important;
border-bottom: 1px solid var(--nypl-colors-ui-border-default) !important;
border-left: 0 !important;
border-right: 0 !important;
border-top: 0 !important;
}
.ds-table-storybook th {
border-bottom: 1px solid var(--nypl-colors-ui-border-default) !important;
border-left: 0 !important;
border-right: 0 !important;
border-top: 1px solid var(--nypl-colors-ui-border-default) !important;
font-size: var(--nypl-fontSizes-desktop-caption);
padding-inline: 1rem !important;
padding-bottom: 1rem !important;
padding-top: 1rem !important;
text-transform: none !important;
}
.ds-table-storybook thead {
background-color: var(--nypl-colors-ui-bg-hover);
th {
font-size: .675rem;
text-transform: uppercase !important;
padding-bottom: .5rem !important;
padding-top: .5rem !important;
}
}
.ds-table-storybook td {
border-bottom: 1px solid var(--nypl-colors-ui-border-default) !important;
border-left: 0 !important;
border-right: 0 !important;
font-size: var(--nypl-fontSizes-desktop-caption);
padding-inline: 1rem !important;
padding-top: 1rem !important;
padding-bottom: 1rem !important;
}
</style>
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,15 @@ Currently, this repo is in Prerelease. When it is released, this project will ad

## Prerelease for Better Breakpoints

### Adds

- Adds and exports `responsiveGutters` and `responsiveSpacing` data objects to make available for consuming apps.

### Updates

- Updates the values for the breakpoints and the associated docs.
- Updates the `viewport` preview options in Storybook to align with the Reservoir breakpoints.
- Updates the `Template` component to implement a responsive 12-column grid system.

## Prerelease

Expand Down
Loading
Loading