Correct scope for visible and make sure visible can be string like ot…

…her callbacks
nytimes · Dec 11, 2012 · e70432c · e70432c
1 parent 5f9a2da
commit e70432c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/backbone.stickit.js b/backbone.stickit.js
@@ -102,7 +102,7 @@
 				// view element.
 				if (config.visible) {
 					visibleCb = function() {
-						updateVisibleBindEl($el, getVal(model, modelAttr, config, self), modelAttr, config, this);
+						updateVisibleBindEl($el, getVal(model, modelAttr, config, self), modelAttr, config, self);
 					};
 					observeModelEvent('change:' + modelAttr, visibleCb);
 					visibleCb();
@@ -231,7 +231,7 @@
 		var visible = config.visible, visibleFn = config.visibleFn, isVisible = !!val;
 
 		// If `visible` is a function then it should return a boolean result to show/hide.
-		if (_.isFunction(visible)) isVisible = applyViewFn(context, visible, val, attrName);
+		if (_.isFunction(visible) || _.isString(visible)) isVisible = applyViewFn(context, visible, val, attrName);
 
 		// Either use the custom `visibleFn`, if provided, or execute a standard jQuery show/hide.
 		if (visibleFn) applyViewFn(context, visibleFn, $el, isVisible, attrName);