Fix select options existence predicate #9

Merged
merged 1 commit into from Sep 26, 2012

Projects

None yet

2 participants

@hlindset
Contributor

Hi.

I encountered some issues with Backbone.stickit on Internet Explorer (tried it on IE7 and IE8). Stickit would always try to get the currently selected option of a select input, even if it was empty. Here's what I found:

  • $el[0].options would always evaluate to true even if the select object didn't have any option elements. So instead I'm checking if its length is truthy.
  • selectedIndex would evaluate to true, because when there is no selected item selectedIndex equals -1. Instead I'm checking whether or not it's equal or greater than zero.
@hlindset hlindset fix select options existence predicate
- `$el[0].options` would always evaluate to `true`
  even if the select object didn't have any option
  elements. So instead we're checking if the
  length is truthy.
- `selectedIndex` would evaluate to `true` because
  when there is no selected item `selectedIndex`
  equals `-1`

So in essence, stickit would try to get the
current selected option value even though there
were no options. This caused an issue on Internet
Explorer (tested in IE7 and IE8), where it would
fail when stickit tried to access the
`selectedIndex` of the select tag's options array.
95bb930
@delambo delambo merged commit c624886 into NYTimes:master Sep 26, 2012
@delambo
Member
delambo commented Sep 26, 2012

@hlindset Once again, you have been very detailed and helpful - thank you, kind sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment