Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select options existence predicate #9

Merged
merged 1 commit into from Sep 26, 2012

Commits on Sep 26, 2012

  1. fix select options existence predicate

    - `$el[0].options` would always evaluate to `true`
      even if the select object didn't have any option
      elements. So instead we're checking if the
      length is truthy.
    - `selectedIndex` would evaluate to `true` because
      when there is no selected item `selectedIndex`
      equals `-1`
    
    So in essence, stickit would try to get the
    current selected option value even though there
    were no options. This caused an issue on Internet
    Explorer (tested in IE7 and IE8), where it would
    fail when stickit tried to access the
    `selectedIndex` of the select tag's options array.
    hlindset committed Sep 26, 2012
    Configuration menu
    Copy the full SHA
    95bb930 View commit details
    Browse the repository at this point in the history