Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize opencensus for GKE #176

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Initialize opencensus for GKE #176

merged 8 commits into from
Jan 29, 2019

Conversation

gaplyk
Copy link
Contributor

@gaplyk gaplyk commented Jan 29, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 29, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 47.43% when pulling 020d01e on gaplyk:master into b3a5760 on NYTimes:master.

jprobinson
jprobinson suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@jprobinson jprobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started!

I've put in a few comments.

server/kit/stackdriver.go Outdated Show resolved Hide resolved
server/kit/stackdriver.go Outdated Show resolved Hide resolved
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
Oleksii Khliupin added 2 commits January 29, 2019 12:33
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson reviewed Jan 29, 2019
View reviewed changes
server/kit/kitserver.go Outdated Show resolved Hide resolved
jprobinson
jprobinson approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@jprobinson jprobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥅 🌯 !!

@jprobinson jprobinson merged commit 27bac81 into nytimes:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprobinson jprobinson jprobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaplyk @coveralls @jprobinson