-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract GCP Monitoring #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments regarding the package name and how things get registered. Lemme know what you think.
@jprobinson all comments should be addressed, happy to revise more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few notes but this is a great start!
@jprobinson all comments addressed |
Mind also adding a mention of this new package in the repo README? |
@jprobinson i fixed the Go doc, there was already a mention of those variables in the main README, but i also added them to the server/kit README |
@jprobinson fixed the onErr message, let me know if there's anything else that needs updating. Thanks! |
Ah shoot, sorry. I just noticed we're referencing the mention in the root README.md of the project. The blurb used for the project level doc should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📈 ! 🌯 ! Thanks for your patience, @marwan-at-work!
gcputil
package (following ioutil/serverutil pattern)server/kit
into the new package so that SimpleServer or really any Go program can initialize metrics/tracing.RegisterOpenCensus
which makes it easier for the user to just call this function, without having to manually get the metadata, insert them into the opts, get the opts, insert the opts into the Exporter.RegisterOpenCensus
with some refactoring in the futurefixes #185