Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests #241

Merged
merged 23 commits into from Oct 21, 2016
Merged

e2e tests #241

merged 23 commits into from Oct 21, 2016

Conversation

ccpricenytimes
Copy link
Contributor

@ccpricenytimes ccpricenytimes commented Oct 11, 2016 •
edited

End to End tests in Jest. They run successfully on the CI server. Just testing very basic functionality for now. Fixes #162

@ccpricenytimes ccpricenytimes changed the title WIP: e2e tests e2e tests Oct 16, 2016
jaredmcdonald
jaredmcdonald reviewed Oct 18, 2016
View reviewed changes
Copy link
Contributor

@jaredmcdonald jaredmcdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think eventually we'll want to get more granular, but these look good to me as a first pass (maybe we can consider these smoke tests and build it out over time)

@jaredmcdonald jaredmcdonald merged commit 46b95de into master Oct 21, 2016
@jaredmcdonald jaredmcdonald deleted the e2e-tests branch October 21, 2016 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmcdonald jaredmcdonald jaredmcdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccpricenytimes @jaredmcdonald @tizmagik