Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using drag & drop for video window, limit the trajectory upwards #249

Closed
ceciliabjork opened this issue Feb 7, 2023 · 3 comments · Fixed by #274
Closed

When using drag & drop for video window, limit the trajectory upwards #249

ceciliabjork opened this issue Feb 7, 2023 · 3 comments · Fixed by #274
Assignees
@saxjax
Labels
2 priority 2 Would be nice to have at next presentation bug Something isn't working DONE Ready for review
Milestone
Milestone 27th of...

Comments

@ceciliabjork
Copy link

ceciliabjork commented Feb 7, 2023 •
edited
Loading

...so that the upper border video window does not get hidden because then the window gets stuck under the tabs ;)
@saxjax saxjax added this to the Milestone April 2023 milestone Mar 15, 2023
@saxjax saxjax added 2 priority 2 Would be nice to have at next presentation bug Something isn't working labels Mar 23, 2023
@saxjax saxjax self-assigned this Mar 24, 2023
@saxjax
Copy link
Collaborator

saxjax commented Mar 24, 2023

use the bounds =
"body"
"parent"
{{top: bottom: left: right:}}
https://www.npmjs.com/package/react-draggable#draggable-usage
image

@saxjax
Copy link
Collaborator

saxjax commented Mar 25, 2023

removed margin on Overlay
set bounds to "parent"

@saxjax saxjax linked a pull request Mar 25, 2023 that will close this issue
Draggable bounds, keep plugin window on screen #274
Merged
@saxjax
Copy link
Collaborator

saxjax commented Mar 25, 2023

PR: #274

solution: https://deploy-preview-274--notio-novia-fi.netlify.app

@saxjax saxjax added the DONE Ready for review label Mar 25, 2023
@saxjax saxjax closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saxjax saxjax

Labels
2 priority 2 Would be nice to have at next presentation bug Something isn't working DONE Ready for review
Projects
None yet
Milestone
Milestone 27th of April 2023
Development

Successfully merging a pull request may close this issue.

Draggable bounds, keep plugin window on screen NYUMusEdLab/notio
2 participants
@saxjax @ceciliabjork