Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull new changes #2

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Pull new changes #2

merged 3 commits into from
Sep 30, 2020

Conversation

NZLostboy
Copy link
Owner

Pull Request Template

Description

Please, include a summary of the patch and why it should be accepted.
Link it to any open issue and share any other information and context you judge relevant for this PR.

Fixes # (issue)

How Has This Been Tested?

Please, describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • My commit message follow the pattern described in here
  • I have signed-off my commit (git commit -s) to certify I have the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see http://developercertificate.org/ for more information).
  • My code follows the style guidelines of this project and I have run make check-local to confirm it.
  • I have run make to build the project and update any documentation that was added as part of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (Run make check to confirm it)

TheGreatGooo and others added 3 commits September 2, 2020 21:42
@TheGreatGooo @alinefm
Prevent errors due to concurrent modification
13a4f59 
Currently if tasks_queue is modified while the for loop is executing, an error is produced
@alinefm
Fix kimchi-project#299: Do not use cherrypy.lib.reprconf.Parser() to …
25c5b2a 
…load plugin config

Cherrypy Parser has a bug that is returning a Constant instead of strings.
Overcome this problem by manually parsing plugin configuration file into a dict.

Partial fixes kimchi#1318 as well.

Signed-off-by: Aline Manera <aline.manera@gmail.com>
@NZLostboy
Merge pull request #1 from kimchi-project/master
7de99a2 
Pull current changes
@NZLostboy NZLostboy merged commit 8fb0042 into patch-1 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NZLostboy @TheGreatGooo @alinefm