[#173] Boto3 client kwargs passthrough

[nk9]

I have not tested this! I don't have an SRP setup.

Please test it @Amejonah1200 and let me know if this will do what you need.

[Amejonah1200]

It looks functional, but this solution doesn't allow IDEs to check for parameters (also mo auto-complete) and it has a sideeffect of modifying input dictionary.

[nk9]

This is true. Here is the list of parameters accepted by the function. And these are the ones missing right now:

• api_version
• aws_session_token
• use_ssl
• verify
• endpoint_url

So this PR would allow all 5 of those to be set as needed, and with a minimum of code changes, but at the expense of missing IDE sugar. I could also do it with **kwargs in the signature, but that won't improve the experience for IDE users.

Thoughts @pvizeli?

[Amejonah1200]

You can also just make them return default values, this would also not require code changes (add also type hints).

[nk9]

I understand what you're suggesting, but I'm saying it's a larger change because then we have to declare all the variables twice, pass them into the utils function, and then conditionally pack them into the dictionary to be unpacked again into the client function call. I'm looking for guidance from the maintainer as to what approach he'd prefer.

[pvizeli]

I'm fine with that approach, pycognito is an wrapper around boto3 cognito. We doing things like this on other place too. Agree, maybe not that optimal, but if someone will add typehints, that work with TypedDicts. Fine for me to ditch support for python < 3.8

[nk9]

Great, thanks. BTW, I've run the code now and verified that it's succesfully passing values through.

[Amejonah1200]

Thanks everyone!