Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require usage of single quotes for docker -e parameter (otherwise subsitutions do happen) #91

Closed
Nachtfeuer opened this issue Jun 13, 2018 · 2 comments
Assignees
Labels

Comments

@Nachtfeuer
Copy link
Owner

Following problem:

FOO="\${}" spline
...
2018-06-13 15:15:08,595 - spline.components.bash - Running script /tmp/pipeline-script-Kj8mAR.sh
2018-06-13 15:15:08,612 - spline.components.tasks -  | /tmp/pipeline-script-Kj8mAR.sh: line 24: FOO=${}: bad substitution
2018-06-13 15:15:08,612 - spline.components.bash - Exit code has been 1
...

Simple pipeline demo for that issue (as sufficient):

pipeline:
  - stage(demo):
      - tasks(ordered):
        - docker(container):
            script: |
              echo "hello"
@Nachtfeuer Nachtfeuer changed the title Bad escaping in environment variables values Require usage of single quotes for docker -e parameter (otherwise subsitutions do happen) Jun 13, 2018
@Nachtfeuer
Copy link
Owner Author

Solution: -e 'FOO=${}' instead of double quotes!

@Nachtfeuer Nachtfeuer added the bug label Jun 13, 2018
@Nachtfeuer Nachtfeuer added this to the Milestone 1.10 milestone Jun 13, 2018
@Nachtfeuer Nachtfeuer self-assigned this Jun 13, 2018
Nachtfeuer pushed a commit that referenced this issue Jun 13, 2018
@Nachtfeuer
Copy link
Owner Author

done

Nachtfeuer pushed a commit that referenced this issue Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant