Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modern Dart projects #21

Conversation

creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Jun 24, 2020

Because of the SDK constraints, non-sound null safety does not work with this plugin → need to change the constraint in some way or potentially create a Dart issue.

@creativecreatorormaybenot creativecreatorormaybenot marked this pull request as ready for review June 24, 2020 02:30
@Naddiseo
Copy link
Owner

Hi, sorry for not responding sooner, the notification got lost.

Firstly, thank you for the PR! I've not been keeping up-to-date with changes in Dart, so these MR help.
Could you link me to the dart documentation saying that support for dart <= 2 is mutually exclusive for dart >=3? I'd like to include it in the readme (mostly for my own sake).

I'm going to try make some time this weekend to review this, and other outstanding issues.

@Naddiseo Naddiseo self-assigned this Jul 14, 2020
@creativecreatorormaybenot
Copy link
Contributor Author

@Naddiseo This is a standard 😃

https://dart.dev/tools/pub/pubspec#sdk-constraints

Probably a measure to be able to introduce major breaking changes later on 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants