Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite parser macros as proc_macros #110

Merged
merged 11 commits into from Sep 2, 2019
Merged

Rewrite parser macros as proc_macros #110

merged 11 commits into from Sep 2, 2019

Conversation

Nadrieril
Copy link
Owner

@Nadrieril Nadrieril commented Sep 2, 2019

Benefits:

  • the parser code is wayyy less magical
  • better error messages when a comma is missing
  • it is finally possible to parse directly an Expr<E> for any E
  • rustfmt accepts to format the parser code
  • parser macros could be published as a useful independent crate
  • rule aliasing and shortcutting can now be reimplemented
  • more possibilities of future extension

@Nadrieril Nadrieril merged commit a92d092 into master Sep 2, 2019
@Nadrieril Nadrieril deleted the parser-proc-macro branch September 2, 2019 21:15
@Nadrieril Nadrieril mentioned this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant