-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Text/replace #181
Conversation
I have made a PR to change the standard: dhall-lang/dhall-lang#1084 |
Thanks for your help, I was dreading to have to implement it myself! My comments are actually about the standard I think, so we'll have to wait for their decision. Code looks great otherwise, I can see you've become familiar with the codebase ^^
Yes feel free to disable tests that fail for now |
afdb0f1
to
5ca9747
Compare
I have reverted back to the simpler (correct) interpolation rules 😄 |
a0c9a3f
to
539e44f
Compare
Code looks great :) Just some suggestions left |
Great! You may go ahead and merge it now, or you can wait for the corresponding dhall-lang PR to get merged if you think it makes more sense |
Great! 😄 Yes I think I will wait for the dhall-lang PR to be accepted first, so I can point the submodule to dhall-lang master instead of my fork! |
9c917cc
to
0f2522a
Compare
I have pointed the dhall-lang submodule towards the latest |
Perfect, thanks! Are there any other changes than the new |
I think From this changelog, other than |
Great :) I've released 0.7.4 with this PR in |
This PR implements the new built-in
Text/replace
which is part of standard v19.0 (tracking issue #180)There is one test that currently fails. I believe it is an issue with the way the standard is currently specified around text replacement with Text that isn't fully evaluated. My understanding is that this specific case should get fixed in a future revision of the standard dhall-lang/dhall-lang#1065
Should I disable this
Text/replace
failing test? What about tests for other v19.0 features (with
built-in), should I temporarily disable them until they get implemented?