Render engine, closes #26

[Abergard]

This change is 

[Abergard]

Review status: 72 of 84 files reviewed at latest revision, 18 unresolved discussions.

---

cmake/platforms/Linux.cmake, line 1 at r3 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

"Detected GNU CXX compiler.")
Shouldn't this be in cmake for GCC?

Done.

---

src/graphics/core/RendererPoolSfml.ut.cpp, line 148 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Could you write what should happen in this scenario?

Done.

---

src/graphics/core/SfmlRectangleShape.hpp, line 4 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Do you use it?

Done.

---

src/graphics/core/SfmlRectangleShape.ut.cpp, line 24 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

What about less then?

I removed them. We don't need to compare shapes in that way now. Done.

---

src/graphics/core/SfmlRenderTarget.ut.cpp, line 21 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Please rename test to more descriptive.

Done.

---

src/graphics/core/WindowSfml.ut.cpp, line 77 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

prepare_events returns int, maybe rename to number_of_expected_events?

Done.

---

src/graphics/core/WindowSfml.ut.cpp, line 91 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

prepare_events returns int, maybe rename to number_of_expected_events?

Done.

---

src/graphics/includes/graphics/Window.hpp, line 8 at r3 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Window() = default; // Q: Is it a good idea
                    // to add default constructors to Interface
Window(const Window&) = default;
Window(Window&&) = default;

I don't thing we should add any constructor at all, this interface does not have any member, so see no need for adding it.

Done.

---

src/graphics/types/Position2f.hpp, line 15 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/graphics/types/Position2f.hpp, line 19 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/graphics/types/Size2f.hpp, line 16 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/graphics/types/Size2f.hpp, line 20 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/graphics/types/WindowSize.hpp, line 16 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/graphics/types/WindowSize.hpp, line 20 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Maybe delegate to own constructor to avoid code duplication?

Done.

---

src/math/includes/math/Position2f.hpp, line 29 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Please consider extract std::tie(*) to avoid code duplication

Done.

---

src/math/includes/math/Size2.hpp, line 24 at r4 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Please consider extract tie(*) to avoid code duplication

Done.

---

src/graphics/src/SfmlRectangleShape.cpp, line 10 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

OK

Not applicable any more.

---

Comments from Reviewable

[kn65op]

Reviewed 5 of 90 files at r2, 9 of 61 files at r4, 21 of 21 files at r6.
Review status: all files reviewed at latest revision, 18 unresolved discussions.

---

Comments from Reviewable

[kn65op]

---

Review status: all files reviewed at latest revision, 18 unresolved discussions.

---

Comments from Reviewable

[kn65op]

Reviewed 2 of 90 files at r2, 2 of 61 files at r4, 15 of 17 files at r7.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/game/SimpleMap.cpp, line 14 at r7 (raw file):

    {
        physics_ids.push_back(physics_engine.register_colider(
            {static_cast<float>(generated_walls.second.first),

I assume that would be better that generator generate floats.

---

src/graphics/core/SfmlRenderTarget.ut.cpp, line 12 at r7 (raw file):

namespace graphics
{
class RenderTargetBaseFunctionsTest : public Test

Interesting solution, however I am not sure if we want to test wrappers.
Let's wait for others to discuss.

I think we can keep it, but think if other test like this are required.

---

Comments from Reviewable

[Abergard]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/game/SimpleMap.cpp, line 14 at r7 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

I assume that would be better that generator generate floats.

It needs more time to change current implementation. For now I will leave it as it is.

---

src/graphics/core/SfmlRenderTarget.ut.cpp, line 12 at r7 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Interesting solution, however I am not sure if we want to test wrappers.
Let's wait for others to discuss.

I think we can keep it, but think if other test like this are required.

Ok.

---

Comments from Reviewable