Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve process ID checking #1107

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Improve process ID checking #1107

merged 6 commits into from
Feb 28, 2024

Conversation

sawolf
Copy link
Member

@sawolf sawolf commented Feb 20, 2024

Instead of just trying to kill the process in the pidfile and refusing to start if we can't, verify that the process in question is actually an instance of NCPA

…ess in the pidfile and refusing to start if we can't, verify that the process in question is actually an instance of NCPA
@sawolf sawolf requested a review from ne-bbahn February 20, 2024 19:53
@ne-bbahn ne-bbahn added the 3.X.X label Feb 27, 2024
Copy link
Contributor

@ne-bbahn ne-bbahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once my fix is merged into this, then I'll be good to have this merged.
#1115

Improving process checking in MR #1107 so it doesn't crash if NCPA wasn't already running
@ne-bbahn ne-bbahn merged commit 3190450 into dev-v3.0.2 Feb 28, 2024
@ne-bbahn ne-bbahn deleted the 1068-pid-checking branch February 29, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants