add feature to optionally use encrypted connection to db #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os starts up. now it saves a hash and then checks that hash before it sends data (are all hosts same? yes->dont send config data, no->send as normal -- are all timeperiods same? ..etc. etc.) things left to do before this is complete is to make sure ndo2db knows to not destroy the tables every time it starts up like it does now. and then to also be prepared to do it if the need arrises. these additions should be trivial -bh
|
Closing this because the branch in question being merged is no longer relevant and will be removed shortly. I added this as an issue #59 and we will take a look at the changes you made along with whatever is required to make sure --enable-ssl works (and is available) in ndo 3. |
|
@savec80, what distribution were you using to create that patch? I wasn't able to compile it using CentOS 7/mariadb-5.5.64. |
|
Hello Sebastian,
I used RHEL7. However according to
https://dev.mysql.com/doc/refman/5.6/en/mysql-options.html mysql version
5.6 at least is required for db data encryption, so I
used: mysql-community-devel-8.0.13-1 in order to compile it.
Not sure if it's a blocker or not.
Hope that helps.
Cheers.
…On Tue, 17 Dec 2019 at 22:43, Sebastian Wolf ***@***.***> wrote:
@savec80 <https://github.com/savec80>, what distribution were you using
to create that patch? I wasn't able to compile it using CentOS
7/mariadb-5.5.64.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AFIZDZIFYKOA7L6WXQARWRTQZFBW5A5CNFSM4GH2MP5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEBVCQ#issuecomment-566762122>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIZDZLD2YTNTKLRFF6ARIDQZFBW5ANCNFSM4GH2MP5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
Can option for using encrypted connection to database be added to the module?
Please have a look at the patch in attach, where I implemented it.
Also there are added some changes from this commit: 34bf52b in order option --enable-ssl for configure works.
Thanks.
db_ssl.txt