Fix SSL certificate handling & minor printf format fixes #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always load CA certificates if available. Use SSL_CTX_use_certificate_chain_file() to load our public certifcate to allow loading intermediate & root CAs. Verify that certificate & private key match. This allows us to present the full certificate chain during handshake with the intermediate & root CAs stored in either the CA file or certificate file or a combination thereof.
|
Noticed the following items while testing with testssl. With the correct options, can now achieve an A+ grade.
Plus a few fixes to support compiling in a separate build directory. |
|
All of these changes look good to me - thanks for the patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always load CA certificates if available.
Use
SSL_CTX_use_certificate_chain_file()to load our public certifcateto allow loading intermediate & root CAs.
Verify that certificate & private key match.
This allows us to present the full certificate chain during handshake
with the intermediate & root CAs stored in either the CA file or
certificate file or a combination thereof.