Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow disabling the time limit completely
By setting `start_minutes_left` to -1 (or another negative number) the time limit can be disabled. This also disables the in-game messages that report how much time is left every minute. The elasped time is still kept track of, so that the shortest times will appear in the Hall of Fame (in ascending order, counting upwards from 0:00). I changed the `rem_min` to a signed short integer to make this work. (I wonder if `rem_min` was signed in the original DOS source... At least I suppose they did not count on large values, because they used a (signed) `%d` in the formatting string `%d MINUTES LEFT`)
- Loading branch information
Showing
7 changed files
with
56 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d63893f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was:
In the disassembly, the
cmp rem_min, <number>
is followed byjle
andjl
for<=
and<
comparisons.In x86 assembly,
jle
is the signed less-or-equal, while the unsigned version would bejbe
(below-or-equal).Probably most other variables that are currently declared as unsigned were signed instead, but there is no visible difference due to the way they are used. (Boolean variables are a good example of this.)