Add v10 support, drop TYPO3 v8 support #8
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten the
ext_localconf.php
to make it work with v10 again. Since v10 dropped the$_EXTCONF
variable outside the ext_emconf.php declaration file, theExtensionConfiguration
class should be used to get extension configuration. v9 also supports this way of getting extension configuration. This made me decide to drop support for TYPO3 v8.I've updated the composer.json to include TYPO3 v10 versions and removed support for v8 because. I've also cleaned up the ext_emconf declaration file by removing deprecated options. I've updated the requirements and dependencies and removed the php dependency since TYPO3 v9 requires a minimum of php 7.2
Since the extension did not yet have an icon, I've added the New relic logo as extension icon. And I've removed the composer.lock since it shouldn't be shipped with the extension I think. Another approach could be to add it to the
.gitattributes
if you believe this file is necessary.Feel free to give feedback if you don't agree with some approaches. I've never published an extension through to TER, so I don't know if the adjustments to the declaration file are useful. Also the version number should be changed if a new release is published.