Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v10 support, drop TYPO3 v8 support #8

Closed
wants to merge 5 commits into from
Closed

Add v10 support, drop TYPO3 v8 support #8

wants to merge 5 commits into from

Conversation

djcprinse
Copy link
Contributor

I've rewritten the ext_localconf.php to make it work with v10 again. Since v10 dropped the $_EXTCONF variable outside the ext_emconf.php declaration file, the ExtensionConfiguration class should be used to get extension configuration. v9 also supports this way of getting extension configuration. This made me decide to drop support for TYPO3 v8.

I've updated the composer.json to include TYPO3 v10 versions and removed support for v8 because. I've also cleaned up the ext_emconf declaration file by removing deprecated options. I've updated the requirements and dependencies and removed the php dependency since TYPO3 v9 requires a minimum of php 7.2

Since the extension did not yet have an icon, I've added the New relic logo as extension icon. And I've removed the composer.lock since it shouldn't be shipped with the extension I think. Another approach could be to add it to the .gitattributes if you believe this file is necessary.

Feel free to give feedback if you don't agree with some approaches. I've never published an extension through to TER, so I don't know if the adjustments to the declaration file are useful. Also the version number should be changed if a new release is published.

@djcprinse
Copy link
Contributor Author

Closing this pull request because version 1.3.0 has been release and contains TYPO3 v10 support

@djcprinse djcprinse closed this Feb 3, 2021
@NamelessCoder
Copy link
Owner

I decided to go with the other PR since that preserves 8.7 compatibility - hopefully it serves your purposes! ;)

@djcprinse
Copy link
Contributor Author

Sure, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants