Fix footer with CSS to remove flicker on each page load

NamelessMC · Jan 14, 2023 · 006b7b7 · 006b7b7
1 parent 127c9cf
commit 006b7b7
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/custom/templates/DefaultRevamp/css/custom.css b/custom/templates/DefaultRevamp/css/custom.css
@@ -441,8 +441,8 @@ body.pushable>.pusher {
 }
 
 /*
-   *  -[ FOOTER ]-
-   */
+ *  -[ FOOTER ]-
+ */
 
 .ui.footer.segment {
     margin: 1rem 0 -.5rem 0;
@@ -455,6 +455,14 @@ body.pushable>.pusher {
     }
 }
 
+@media only screen and (min-width: 768px) {
+    .ui.footer {
+        position: absolute;
+        bottom: 0;
+        width: 100%;
+    }
+}
+
 .ui.link.list.list .active.item {
     color: rgba(255, 255, 255, .5);
 }

diff --git a/custom/templates/DefaultRevamp/footer.tpl b/custom/templates/DefaultRevamp/footer.tpl
@@ -1,7 +1,7 @@
 </div>
 </div>
 
-<div class="ui inverted vertical footer segment" id="footer">
+<div class="ui inverted vertical footer segment">
     <div class="ui container">
         <div class="ui stackable inverted divided equal height stackable grid">
             <div class="{if $SOCIAL_MEDIA_ICONS|count > 0}six{else}eight{/if} wide column">

diff --git a/custom/templates/DefaultRevamp/js/scripts.js b/custom/templates/DefaultRevamp/js/scripts.js
diff --git a/custom/templates/DefaultRevamp/template.php b/custom/templates/DefaultRevamp/template.php
@@ -140,7 +140,6 @@ public function onPageLoad() {
             $this->_template['path'] . 'js/core/core.js?v=202' => [],
             $this->_template['path'] . 'js/core/user.js' => [],
             $this->_template['path'] . 'js/core/pages.js?v=202' => [],
-            $this->_template['path'] . 'js/scripts.js' => [],
         ]);
 
         foreach ($this->_pages->getAjaxScripts() as $script) {

diff --git a/modules/Core/module.php b/modules/Core/module.php
@@ -199,7 +199,8 @@ public function __construct(Language $language, Pages $pages, User $user, Naviga
                                                     $custom_page->id,
                                                     Output::getClean($custom_page->title),
                                                     (is_null($redirect)) ? URL::build(Output::urlEncodeAllowSlashes($custom_page->url)) : $redirect,
-                                                    'footer', $custom_page->target ? '_blank' : null,
+                                                    'footer',
+                                                    $custom_page->target ? '_blank' : null,
                                                     2000,
                                                     $custom_page->icon
                                                 );