-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp avatar system, remove MC avatars from core #3313
base: develop
Are you sure you want to change the base?
Conversation
9b88f5e
to
c62eb56
Compare
e1a4285
to
eaa1312
Compare
<table class="table table-borderless table-striped"> | ||
<thead> | ||
<tr> | ||
<th>Name</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded text
MinecraftAvatarSource::registerSource(new VisageMinecraftAvatarSource()); | ||
} | ||
|
||
// EventHandler::registerListener(UserIntegrationUnlinkedEvent::class, ResetAvatarCacheHook::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those should be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or wait, this is listeners
public function get(User $user): ?string { | ||
$base_url = ($this->_full_url ? rtrim(URL::getSelfURL(), '/') : '') . ((defined('CONFIG_PATH')) ? CONFIG_PATH . '/' : '/') . 'uploads/avatars'; | ||
|
||
if (Settings::get('custom_user_avatars') && $user->data()->has_avatar) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow custom user avatars? setting on custom avatar source does not save on enabled state
} | ||
|
||
foreach ($exts as $ext) { | ||
if (file_exists(ROOT_PATH . "/uploads/avatars/{$user->data()->id}.{$ext}")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be a way to remove or unselect default custom avatar
People most likey want Custom avatar to be priority one, and minecraft next but if they have uploaded a custom default image then they are not able to fallback to minecraft avatar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that Minecraft Avatar Source should be default priority, Well below Uploading Image source type
So new sites still using Minecraft avatars by default as its still a CMS designed for Minecraft
No description provided.