Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create media from bytes to support sqlite bundle system #884

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Create media from bytes to support sqlite bundle system #884

merged 11 commits into from
Jul 9, 2024

Conversation

bigfoodK
Copy link
Contributor

@bigfoodK bigfoodK commented Jul 6, 2024 •
edited
Loading

Interface Changes

  • new_media(path: &impl AsRef<Path>)
    • to new_media(source: impl Into<MediaSource>)

@bigfoodK bigfoodK added enhancement New feature or request namui This issue is for namui engine labels Jul 6, 2024
@bigfoodK bigfoodK self-assigned this Jul 6, 2024
@bigfoodK bigfoodK requested a review from namse July 6, 2024 01:28
@bigfoodK bigfoodK marked this pull request as ready for review July 6, 2024 01:28
@bigfoodK bigfoodK enabled auto-merge (squash) July 6, 2024 09:55
namse
namse requested changes Jul 6, 2024
View reviewed changes
namui/namui/src/namui/system/media/core/media_source.rs Outdated Show resolved Hide resolved
namui/rust-ffmpeg/src/format/mod.rs Outdated Show resolved Hide resolved
namui/sample/media/src/lib.rs Show resolved Hide resolved
@namse
Copy link
Contributor

namse commented Jul 8, 2024

Give me review request when you ready

@bigfoodK
Copy link
Contributor Author

bigfoodK commented Jul 9, 2024

Track build error on #890

@bigfoodK bigfoodK requested a review from namse July 9, 2024 04:55
namse
namse approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@namse namse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done!

@bigfoodK bigfoodK merged commit 2dd33f4 into master Jul 9, 2024
21 of 33 checks passed
@bigfoodK bigfoodK deleted the namui/media-from-bytes branch July 9, 2024 06:59
@namse
Copy link
Contributor

namse commented Jul 9, 2024

I forgot to add checking post-namui-linux-host-x86_64-unknown-linux-gnu action on branch protection rule, so it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namse namse namse approved these changes

Assignees

@bigfoodK bigfoodK

Labels
enhancement New feature or request namui This issue is for namui engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigfoodK @namse