Skip to content
Browse files

Update src/redis-benchmark.c

The code of current implementation:

if (c->pending == 0) clientDone(c);
In clientDone function, the c's memory has been freed, then the loop will continue: while(c->pending). The memory of c has been freed now, so c->pending is invalid (c is an invalid pointer now), and this will cause memory dump in some platforams(eg: Solaris).

So I think the code should be modified as:
if (c->pending == 0)
{
clientDone(c);
break;
}
and this will not lead to while(c->pending).
  • Loading branch information...
1 parent 278304c commit 9eb3a7bc6ba041ee8f14427a68087459fc8e66f9 @NanXiao committed Oct 10, 2012
Showing with 4 additions and 1 deletion.
  1. +4 −1 src/redis-benchmark.c
View
5 src/redis-benchmark.c
@@ -201,7 +201,10 @@ static void readHandler(aeEventLoop *el, int fd, void *privdata, int mask) {
if (config.requests_finished < config.requests)
config.latency[config.requests_finished++] = c->latency;
c->pending--;
- if (c->pending == 0) clientDone(c);
+ if (c->pending == 0) {
+ clientDone(c);
+ break;
+ }
} else {
break;
}

0 comments on commit 9eb3a7b

Please sign in to comment.
Something went wrong with that request. Please try again.