This repository has been archived by the owner on Apr 26, 2020. It is now read-only.
Accept vendor-specific protocol buffer Accept headers. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned comments better.
grumpydev
added a commit
that referenced
this pull request
Jun 30, 2015
Accept vendor-specific protocol buffer Accept headers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request contained an Accepts header of the form: application/vnd.SOMETHING+x-protobuf, the framework wouldn't recognize it. This broke bind() calls among others.
I lifted the idea for this implementation from another Nancy serializer, but I can't remember where (sorry, I hacked this internally for a project a while ago and I'm just now getting around to sending my patch upstream).
I've also added a few unit tests to verify this behavior. Let me know if I need to tweak this to make the patch acceptable.