This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Prevent OPTIONS route clobber #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the IsOptionsRequest conditional branch to only execute if no defined OPTIONS route for the context exists. Otherwise, even if you define an OPTIONS route manually, the auto-OPTIONS conditional clobbers the Response, preventing custom additions such as CORS headers.
| var results = this.trie.GetMatches(GetMethod(context), context.Request.Path, context); | ||
|
|
||
| if (!results.Any()) | ||
| { | ||
| if (this.IsOptionsRequest(context)) |
There was a problem hiding this comment.
Gotcha. Looks like VS decided tabs was the way to go. I'll fix it.
|
As soon as we've reviewed and pulled in this, then you can use the CI nugets which always reflects master http://www.myget.org/gallery/nancyfx |
grumpydev
added a commit
that referenced
this pull request
May 21, 2013
Prevent OPTIONS route clobber
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the IsOptionsRequest conditional branch to only execute if no
defined OPTIONS route for the context exists. Otherwise, even if you
define an OPTIONS route manually, the auto-OPTIONS conditional clobbers
the Response, preventing custom additions such as CORS headers.
Addresses discussion at 604327a#commitcomment-3148154