Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Add CookieBasedSessionsConfiguration #1409

Merged
merged 4 commits into from Mar 16, 2014
Merged

Add CookieBasedSessionsConfiguration #1409

merged 4 commits into from Mar 16, 2014

Conversation

omeaart
Copy link
Contributor

@omeaart omeaart commented Jan 22, 2014

Problem

It's impossible to edit the domain or the path of the cookie from the CookieBasedSessions

Fix

Add the CookieBasedSessionsConfiguration class to make the session more configurable

Thoughts

  • Please shoot, I did my best to add sufficient tests, but quite possibly I missed some.
  • I let all the original constructors in place to make it all backwards compatible, but maybe it is better to make it a breaking change?

[Fact]
public void Should_not_be_valid_with_empty_cookiename()
{
config.CookieName = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nancy code base prefers this.config to config

@thecodejunkie thecodejunkie added this to the 0.23 milestone Feb 5, 2014
@thecodejunkie
Copy link
Member

Assigned this to the 0.23 release.

thecodejunkie added a commit that referenced this pull request Mar 16, 2014
@thecodejunkie thecodejunkie merged commit 6dbc014 into NancyFx:master Mar 16, 2014
@thecodejunkie
Copy link
Member

❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants