Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Added a MaterialisingResponse #1504

Merged
merged 1 commit into from Apr 5, 2014

Conversation

grumpydev
Copy link
Member

It executes the deferred body immediately and stores the results in memory to be sent on later.

Wired it into the ViewProcessor to catch template execution errors if error traces are on - added a demo for it to the main asp.net project.

Missing tests, so not ready to pull in yet, just putting this here to see if it fits the bill. The error message could be better, but not if there's anything we can do about that - the template has been and gone at that point.

It executes the deferred body immediately and stores the
results in memory to be sent on later.

Wired it into the ViewProcessor to catch template execution
errors if error traces are on.
@thecodejunkie thecodejunkie added this to the 0.23 milestone Apr 5, 2014
thecodejunkie added a commit that referenced this pull request Apr 5, 2014
@thecodejunkie thecodejunkie merged commit 9cef623 into NancyFx:master Apr 5, 2014
@thecodejunkie
Copy link
Member

❤️

@grumpydev
Copy link
Member Author

Lol.. nice review skills boss.. read the description ;)

Maybe lay off those painkillers? 👯

@thecodejunkie
Copy link
Member

hmm, description you say .. 👊

you need a 🚧 sign in there :octocat:

@grumpydev
Copy link
Member Author

It's not a problem, just should probably add a test other than me testing it with F5 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants