Overwrite Content-Type from headers #1723
Conversation
| { | ||
| get | ||
| { | ||
| var header = Headers.Keys.FirstOrDefault(h => h.ToLowerInvariant() == "content-type"); |
There was a problem hiding this comment.
h => String.Equals(h, "Content-Type", StringComparison.OrdinalIgnoreCase)
|
HTTP header fields are case sensitive, so there should be no need to do any case magic. Just grab |
albertjan
force-pushed
the
overwrite-content-type
branch
2 times, most recently
from
ed91d21
to
015e055
Compare
|
Might be better to use a case insensitive dictionary for the headers. But we might break al sorts of apps sneakily relying on case-sensitive headers. |
|
Needs to be ordinal ignore case |
albertjan
force-pushed
the
overwrite-content-type
branch
from
015e055
to
3bef79c
Compare
|
@jchannon Sorry 😄 |
| Response response = value; | ||
|
|
||
| // When | ||
| response.Headers.Add("content-type", "application/json"); |
There was a problem hiding this comment.
Nitpicking: I would wEiRDcaSe the "content-type" string to demonstrate that case is ignored
albertjan
force-pushed
the
overwrite-content-type
branch
from
3bef79c
to
cb5c8ba
Compare
|
Looks like the response headers haven't received the same love as the request headers. Those are kept in a case-insensitive dictionary. See |
|
@khellang soundslike a plan. Not worried about breaking stuff? |
|
I don't mind. I'd actually love to see a |
|
I was feeling a bit of scope creep going on 😄 |
|
@khellang this looks a lot cleaner |
|
Looks good now 👍 |
Overwrite Content-Type from headers
Should overwrite the content-type from the headers when it's set there. Don't you think?