This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Fixed various cookie encoding and decoding issues and related tests #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -355,7 +355,7 @@ private static byte[] GenerateHmac(string encryptedCookie, FormsAuthenticationCo | |||
| public static string DecryptAndValidateAuthenticationCookie(string cookieValue, FormsAuthenticationConfiguration configuration) | |||
| { | |||
| // TODO - shouldn't this be automatically decoded by nancy cookie when that change is made? | |||
There was a problem hiding this comment.
Remove this while you're at it? 😛
|
This fixes #2093 |
khellang
added a commit
that referenced
this pull request
Oct 30, 2015
Fixed various cookie encoding and decoding issues and related tests
|
Thanks! 👍 Let's hope this fixes it 😜 |
fxbit
pushed a commit
to yodiwo/Nancy
that referenced
this pull request
Aug 19, 2016
…ueFix Fixed various cookie encoding and decoding issues and related tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the auth and csrf issues after recent cookie encoding and decoding changes.