This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Change disposal of CancellationTokenSource to after task is complete #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, this is to fix issue #2141 |
| } | ||
| finally | ||
| { | ||
| cts.Dispose(); |
damianh
added a commit
that referenced
this pull request
Dec 7, 2015
…eDisposal Change disposal of CancellationTokenSource to after task is complete
|
There is a PR where the async await stuff is cleaned up for .net 4.5 : https://github.com/NancyFx/Nancy/pull/2105/files#diff-3711e290f8f06e8bd6ce86e1e6ce7dbfR102 I don't think I need to do any special here? |
|
The async/await implementation looks correct to me too |
|
Thanks @jeffthiele-iq |
|
@jeffthiele-iq appreciate your feedback on |
|
Version 1.4.3 was just pushed to NuGet. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was allowing the disposal of the
CancellationTokenSourceto occur before thelifeCycleTaskwas actually complete. I moved the disposal to thecompleteTaskcontinuation so it would only be disposed when the task was complete.Also included is a test that can detect this in the future and also verifies that the token is disposed after the call.
I also ran through the memory leak test in pull request #2128 and (assuming I had my CLI commands correct for dotMemoryUnit) it passed.