This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Embedded Static Content Convention Builder #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var ext = Path.GetExtension(nancyContext.Request.Path); | ||
|
|
||
| return () => new StreamResponse(() => assemblyContainingResource.GetManifestResourceStream(fullyQualifiedResourceName), MimeTypes.GetMimeType(requestPath)); |
There was a problem hiding this comment.
If the resource stream is added directly to the StreamResponse constructor lambda, it gets garbage collected which causes an exception when subsequent Response.Content.Invokes are called. It'd be nice to avoid digging into the manifest every time the response is invoked but I'm not sure how to accomplish that.
|
Will probably need rebasing, but we will likely pull the embedded stuff into an auto-wiring nuget. |
|
This is what we have in mind #732 |
|
Closing this as it won't be merged directly but ported for #732. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analagous to the StaticContentConventionBuilder but for files that are embedded resources